Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make criterion a dev-dependency #1245

Closed
wants to merge 1 commit into from

Conversation

pitdicker
Copy link
Collaborator

No description provided.

@codecov
Copy link

codecov bot commented Sep 2, 2023

Codecov Report

Merging #1245 (aadabc1) into 0.4.x (243d26d) will decrease coverage by 0.28%.
Report is 8 commits behind head on 0.4.x.
The diff coverage is n/a.

@@            Coverage Diff             @@
##            0.4.x    #1245      +/-   ##
==========================================
- Coverage   86.10%   85.82%   -0.28%     
==========================================
  Files          37       37              
  Lines       13522    13517       -5     
==========================================
- Hits        11643    11601      -42     
- Misses       1879     1916      +37     

see 5 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@pitdicker
Copy link
Collaborator Author

Run cargo test --lib \
    Updating crates.io index
error: failed to select a version for the requirement `clap = "^4"`
candidate versions found which didn't match: 3.2.25, 3.2.24, 3.2.23, ...
location searched: crates.io index
required by package `criterion v0.5.1`
    ... which satisfies dependency `criterion = "^0.5.1"` of package `chrono v0.4.28 (/home/runner/work/chrono/chrono)`
Error: Process completed with exit code 101.

Same result as in #1104 (comment) when making criterion a dev-dependency 😞

@pitdicker pitdicker closed this Sep 2, 2023
@pitdicker pitdicker deleted the criterion_dev_dep branch September 8, 2023 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant