Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: test cross-compiling to x86_64-unknown-illumos instead of Solaris #1437

Merged
merged 1 commit into from Feb 13, 2024

Conversation

pitdicker
Copy link
Collaborator

Apparently cross dropped support for the x86_64-sun-solaris target (cross-rs/cross#1432), making our CI fail.

Copy link

codecov bot commented Feb 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b4d5ff) 91.85% compared to head (3df7ede) 91.85%.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1437   +/-   ##
=======================================
  Coverage   91.85%   91.85%           
=======================================
  Files          40       40           
  Lines       17469    17469           
=======================================
  Hits        16046    16046           
  Misses       1423     1423           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@djc
Copy link
Contributor

djc commented Feb 13, 2024

@steveklabnik as someone who might know some Illumos users, do you happen to have any feedback on this? Is this the right thing to be doing? (Not sure if Oxide systems end up using chrono somehow.)

@steveklabnik
Copy link
Contributor

Thanks for the cc, I have pinged work chat, let's see.

@steveklabnik
Copy link
Contributor

Yeah, this seems good: x86_64-unknown-illumos is the target we actually use. Thanks again for checking in!

@pitdicker
Copy link
Collaborator Author

@steveklabnik Thank you!

@pitdicker pitdicker merged commit 4d4ff14 into chronotope:main Feb 13, 2024
37 checks passed
@pitdicker pitdicker deleted the fix_ci_solaris branch February 13, 2024 21:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants