Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Mdf performance and docs #1438

Merged
merged 10 commits into from Feb 14, 2024
Merged

Mdf performance and docs #1438

merged 10 commits into from Feb 14, 2024

Commits on Feb 14, 2024

  1. Add benchmark for NaiveDate::from_ymd

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    cdbf10e View commit details
    Browse the repository at this point in the history

  2. Add doc comments to Mdf methods

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    b8112c1 View commit details
    Browse the repository at this point in the history

  3. Mdf::new: remove checks that are also done by the table lookup

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8c5b02a View commit details
    Browse the repository at this point in the history

  4. Don't use NaiveDate::from_ordinal_and_flags in from_mdf 

    It introduced a couple of extra checks in performance-sensitive code.
    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    71ac01e View commit details
    Browse the repository at this point in the history

  5. Use NonZeroI32::new_unchecked

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    2cdf733 View commit details
    Browse the repository at this point in the history

  6. Comparing against zero is slightly faster

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    6545c6f View commit details
    Browse the repository at this point in the history

  7. Casting a positive i8 through u8 is slightly faster

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    ad9727e View commit details
    Browse the repository at this point in the history

  8. Simplify test-only Mdf::valid method

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    8ecd0e9 View commit details
    Browse the repository at this point in the history

  9. MAX_OL and MAX_MDL can be private

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    0393cca View commit details
    Browse the repository at this point in the history

  10. Extend YearFlags documentation/constants

    @pitdicker
    pitdicker committed Feb 14, 2024
    Configuration menu
    Copy the full SHA
    81a52a9 View commit details
    Browse the repository at this point in the history