Disable wasmbind feature by default #1472
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This removes `wasmbind` from the default feature set, which stops chrono from implicitly depending upon wasm-bindgen and js-sys. This is helpful for a few reasons: * It reduces the default dependency set by default for non-wasm projects, which shrinks the download size. * Projects like Fuchsia have a policy where 3rd party crates need to be audited. While we don't use wasm-bindgen, we can't opt out of it by setting `default-features = false` because of [feature unification] ends up enabling chrono's default feature. See this [cargo issue] for more details. `wasm-bindgen` is large and complicated, so it's pretty expensive for us to update. Fixes chronotope#1164 [feature unification]: https://doc.rust-lang.org/cargo/reference/features.html#feature-unification [cargo issue]: rust-lang/cargo#4463
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1472 +/- ##
=======================================
Coverage 94.34% 94.34%
=======================================
Files 37 37
Lines 17009 17009
=======================================
Hits 16047 16047
Misses 962 962 ☔ View full report in Codecov by Sentry. |
pitdicker
approved these changes
Feb 29, 2024
|
Thanks! |
|
I would like to know the plan for releasing |
|
If you are in a position to remove chrono, you probably are also in the position to use it without default features? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes
wasmbindfrom the default feature set, which stops chrono from implicitly depending upon wasm-bindgen and js-sys. This is helpful for a few reasons:It reduces the default dependency set by default for non-wasm projects, which shrinks the download size.
Projects like Fuchsia have a policy where 3rd party crates need to be audited. While we don't use wasm-bindgen, we can't opt out of it by setting
default-features = falsebecause of feature unification ends up enabling chrono's default feature. See this cargo issue for more details.wasm-bindgenis large and complicated, so it's pretty expensive for us to update.While I'd love to land this in the main branch, it's technically a breaking issue since downstream dependencies are probably not enabling the
wasmbindfeature if they need it.Fixes #1164