Convert TryFrom<SystemTime> to our error type
#1524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## 0.5.x #1524 +/- ##
=======================================
Coverage 94.01% 94.01%
=======================================
Files 37 37
Lines 16830 16830
=======================================
Hits 15823 15823
Misses 1007 1007 ☔ View full report in Codecov by Sentry. |
pitdicker
force-pushed
the
try_from_systemtime
branch
from
6586aff
to
948767f
Compare
pitdicker
force-pushed
the
try_from_systemtime
branch
from
948767f
to
d6d56e0
Compare
djc
approved these changes
Mar 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This does not yet convert
TryFrom<SystemTime> for DateTime<Local>.I'd like to work on the methods that can have a failure cause in the
TimeZonetrait later.