Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Convert checked_add_months, checked_sub_months to return Result #1537

Merged
merged 2 commits into from
Mar 25, 2024

Conversation

pitdicker
Copy link
Collaborator

Last pieces of NaiveDate and NaiveDateTime 🎉 (except parsing).

Copy link

codecov bot commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 98.07692% with 1 lines in your changes are missing coverage. Please review.

Project coverage is 93.95%. Comparing base (08c9792) to head (5fdb9f4).

Files Patch % Lines
src/naive/date/mod.rs 94.73% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##            0.5.x    #1537      +/-   ##
==========================================
- Coverage   93.98%   93.95%   -0.03%     
==========================================
  Files          37       37              
  Lines       16656    16591      -65     
==========================================
- Hits        15654    15588      -66     
- Misses       1002     1003       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker changed the title Convert checked_add_days, checked_sub_days to return Result Convert checked_add_months, checked_sub_months to return Result Mar 22, 2024
@pitdicker pitdicker force-pushed the convert_add_months branch 2 times, most recently from 7b5811d to 4d47ea6 Compare March 22, 2024 19:42
@pitdicker pitdicker merged commit 83de26d into chronotope:0.5.x Mar 25, 2024
35 checks passed
@pitdicker pitdicker deleted the convert_add_months branch March 25, 2024 14:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants