Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Reduce combinations in cargo hack check #1553

Merged
merged 2 commits into from
Apr 4, 2024

Conversation

pitdicker
Copy link
Collaborator

I'm not sure why but within the last week the combinations cargo hack check tries on our CI has increased 4x to 672. Cargo hack has seen a couple of new releases, so there may be a change or bugfix there.

Disabling the oldtime (unused) and wasmbind (not checked on linux anyway) features reduces it back to 192 combinations.

We can also now inform cargo hack that some features are mutually exclusive, or don't effect each other. The rkyv features are truly mutually exclusive. The arbitrary feature is far removed from serialization, and serde also doesn't seem to have anything in common with rkyv. So I think we can treat them as mutually exclusive.

This allows us to run cargo hack check for more meaningful combinations with the rkyv-* features while we only check 84 combinations. Room to grow again 馃槃.

This should bring our CI time back below 5 minutes instead of close to 20 minutes.

Copy link

codecov bot commented Apr 4, 2024

Codecov Report

All modified and coverable lines are covered by tests 鉁

Project coverage is 91.78%. Comparing base (ffe2745) to head (226ddc2).
Report is 7 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1553      +/-   ##
==========================================
- Coverage   91.79%   91.78%   -0.01%     
==========================================
  Files          37       37              
  Lines       18175    18167       -8     
==========================================
- Hits        16683    16674       -9     
- Misses       1492     1493       +1     

鈽 View full report in Codecov by Sentry.
馃摙 Have feedback on the report? Share it here.

@pitdicker
Copy link
Collaborator Author

4m3s 馃槃.

Copy link
Contributor

@djc djc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good stuff!

@pitdicker pitdicker merged commit 8b1364f into chronotope:main Apr 4, 2024
35 checks passed
@pitdicker pitdicker deleted the cargo_hack_check branch April 4, 2024 07:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants