Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Manually implement Copy for DateTime if offset is Copy #1573

merged 2 commits into from
Apr 15, 2024


Copy link

Also extended the test to have the type that implements Offset be Send and Copy while the type for TimeZone is not.

Fixes #1571.

@pitdicker pitdicker changed the title Datetime copy send Manually implement Copy for DateTime if offset is Copy Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

Attention: Patch coverage is 75.67568% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 91.78%. Comparing base (760eb66) to head (74b371a).

Files Patch % Lines
src/datetime/ 75.67% 9 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1573      +/-   ##
- Coverage   91.82%   91.78%   -0.04%     
  Files          37       37              
  Lines       18173    18208      +35     
+ Hits        16687    16713      +26     
- Misses       1486     1495       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pitdicker pitdicker merged commit 352a352 into chronotope:main Apr 15, 2024
34 of 35 checks passed
@pitdicker pitdicker deleted the datetime_copy_send branch April 15, 2024 09:51
Copy link
Collaborator Author

Published 🎉.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
None yet
None yet

Successfully merging this pull request may close these issues.

0.4.37 semver-incompatibly removes trait bounds on DateTime
2 participants