Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Allow parsing of timestamps with additional subsecond precision #176

Merged
merged 2 commits into from
Jul 15, 2017
Merged

Fix Allow parsing of timestamps with additional subsecond precision #176

merged 2 commits into from
Jul 15, 2017

Conversation

jonasbb
Copy link
Contributor

@jonasbb jonasbb commented Jul 14, 2017

Fixes #175

@quodlibetor
Copy link
Contributor

Nice! Could you add a test to chrono::naive::datetime::test_datetime_parse_from_str that verifies the behavior as well?

@quodlibetor
Copy link
Contributor

actually that method could use both a %S.%f and plain %S test, if you're willing.

@jonasbb
Copy link
Contributor Author

jonasbb commented Jul 15, 2017

I have added additional test for each of the %f variants.

@quodlibetor quodlibetor merged commit 5c0b773 into chronotope:master Jul 15, 2017
@quodlibetor
Copy link
Contributor

Awesome, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jonasbb @quodlibetor