Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support round tripping display <-> datetime #378

Merged
merged 1 commit into from
Dec 30, 2019

Conversation

quodlibetor
Copy link
Contributor

This extens FromStr to allow either a T or a (space) as the delimiter
between the date and the time, and, because of the fact that the Z
parser-specifier is shared with the Fixed notation, extends the fixed notation
to support UTC in addition to Z as the zero-offset.

IMO this Fixes #147

@quodlibetor quodlibetor force-pushed the round-trip-display branch 3 times, most recently from 7b7bba7 to acbb363 Compare December 27, 2019 18:47
@quodlibetor
Copy link
Contributor Author

Interestingly enough perf with this is pretty much completely unchanged.

image

This extends `FromStr` to allow either a `T` or a ` ` (space) as the delimiter
between the date and the time, and, because of the fact that the `Z`
parser-specifier is shared with the Fixed notation, extends the fixed notation
to support `UTC` in addition to `Z` as the zero-offset.

IMO this Fixes chronotope#147
@quodlibetor quodlibetor merged commit 4ad95ee into chronotope:master Dec 30, 2019
@quodlibetor quodlibetor deleted the round-trip-display branch December 30, 2019 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Consider including the T in Display of DateTime
1 participant