Skip IANA TZ names when parsing %Z specifier #473
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
quodlibetor
reviewed
Aug 16, 2020
Done and done
Well, it's a lot of work with so little payoff. Also, I probably should have provided a link to the glibc source code to simplify the verification, sorry for that |
No apologies necessary, it was straightforward to verify. Thanks, very much for this! |
erickt
added a commit
to erickt/valico
that referenced
this pull request
Jan 19, 2022
In chronotope/chrono#473, chrono changed how %Z is handled, and was changed to simply skip over any non-whitespace characters in the timezone section, just like glibc's `strptime`. I'm not sure if this is the right fix, but it gets the tests to pass.
erickt
added a commit
to erickt/valico
that referenced
this pull request
Jan 19, 2022
In chronotope/chrono#473, chrono changed how %Z is handled, and was changed to simply skip over any non-whitespace characters in the timezone section, just like glibc's `strptime`. I'm not sure if this is the right fix, but it gets the tests to pass.
pickfire
pushed a commit
to pickfire/chrono
that referenced
this pull request
Jan 22, 2022
botahamec
pushed a commit
to botahamec/chrono
that referenced
this pull request
May 26, 2022
pickfire
pushed a commit
to pickfire/chrono
that referenced
this pull request
Jul 5, 2022
fourkbomb
pushed a commit
to fourkbomb/valico
that referenced
this pull request
Nov 11, 2022
In chronotope/chrono#473, chrono changed how %Z is handled, and was changed to simply skip over any non-whitespace characters in the timezone section, just like glibc's `strptime`. I'm not sure if this is the right fix, but it gets the tests to pass.
s-panferov
pushed a commit
to s-panferov/valico
that referenced
this pull request
Feb 2, 2023
In chronotope/chrono#473, chrono changed how %Z is handled, and was changed to simply skip over any non-whitespace characters in the timezone section, just like glibc's `strptime`. I'm not sure if this is the right fix, but it gets the tests to pass.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for contributing to chrono!
about adding the PR number)
we can't reintroduce it?
This PR prevents
%Zspecifier from causing an instant parsing failure, instead, skipping chars until the next whiltespace-like char, as implemented in glibc strptime.