Cleanups #661
Merged
Cleanups #661
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
djc
force-pushed
the
cleanups
branch
3 times, most recently
from
b8b4694
to
013507c
Compare
Milo123459
reviewed
Mar 22, 2022
| use crate::offset::{FixedOffset, LocalResult, TimeZone, Utc}; | ||
| use core::fmt; | ||
| use core::ops::Deref; | ||
| use rustc_serialize::{Decodable, Decoder, Encodable, Encoder}; |
There was a problem hiding this comment.
Why use rustc_serialize? Serde?
There was a problem hiding this comment.
I'm not making any backwards incompatible changes here, so that means keeping rustc_serialize.
Milo123459
approved these changes
Mar 22, 2022
Do you mean that we should enable the serde feature by default? I don't agree -- most well-maintained libraries keep it as an off-by-default feature, so that downstream users who don't need it don't have to compile the extra dependency. |
This was referenced Mar 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal here is to make the codebase easier to navigate and take advantage of the MSRV upgrade from #653 to employ more modern Rust standards.