Test Local functions against date command #682
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
esheppa
changed the title
djc
reviewed
Apr 30, 2022
src/offset/local/mod.rs
Outdated
| // avoid running this on macOS, temporarily | ||
| // for date_path in ["/usr/bin/date", "/bin/date"] { | ||
| for date_path in ["/usr/bin/date"] { | ||
| if path::Path::new(date_path).exists() { |
There was a problem hiding this comment.
Can you make this use an early continue? That would help reduce rightward drift.
There was a problem hiding this comment.
good call, the code was a bit gnarly, I've made some improvements by using NaiveDateTime instead
There was a problem hiding this comment.
I removed the loop across date commands as I tried this out on macOS, but I couldn't find the same command line arguments and so wasn't able the replicate the behavior desired to find the local timezone
esheppa
added a commit
to esheppa/chrono
that referenced
this pull request
May 13, 2022
djc
pushed a commit
that referenced
this pull request
May 13, 2022
djc
pushed a commit
that referenced
this pull request
Jun 8, 2022
djc
pushed a commit
that referenced
this pull request
Jun 9, 2022
djc
pushed a commit
that referenced
this pull request
Jun 9, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is split from #678 and just adds the extra tests