Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add LocalOffset type that stores the timezone name #750

Closed
wants to merge 2 commits into from

Conversation

esheppa
Copy link
Collaborator

@esheppa esheppa commented Jul 31, 2022

This could also be implemented as an extra field on FixedOffset, which would mean it would no longer be a breaking change, but in that case it would make the FixedOffset type more than three times larger.

This should fix #749 on unix platforms. We would need to capture timezone name on Windows as well, potentially from here hence why this is in draft status for now

@esheppa esheppa added the API-incompatible Tracking changes that need incompatible API revisions label Jul 31, 2022
@esheppa esheppa marked this pull request as draft July 31, 2022 13:09
@esheppa esheppa added this to the 0.5 milestone Aug 10, 2022
@pamburus
Copy link

Hi, what stops this pull request from being fixed and merged?

@pitdicker
Copy link
Collaborator

pitdicker commented Apr 26, 2023

We would need to capture timezone name on Windows as well, potentially from here hence why this is in draft status for now

The TIME_ZONE_INFORMATION structure doesn't seem to play along. The documentation says it returns names such as "EST" and "PDT", but in reality it returns full, localized names instead. We would need some other source.

Edit: StandardName and DaylightName are localized, TimeZoneKeyName has a full, unlocalized name.

@pitdicker
Copy link
Collaborator

pitdicker commented Apr 7, 2024

Closing this PR for now because realistically there have been enough changes that it is easier to start fresh. #1563 tracks adding a LocalOffset type.

@esheppa Thank you for your work here!

@pitdicker pitdicker closed this Apr 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API-incompatible Tracking changes that need incompatible API revisions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong output from %Z specifier when using Local::now().format()
3 participants