Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify serde module contains defaults too in docs #777

Merged
merged 2 commits into from
Aug 15, 2022

Conversation

alextes
Copy link
Contributor

@alextes alextes commented Aug 13, 2022

Makes it more clear the serde module isn't only for alternatives it
is also required for the default implementations.

Adds a small hint in italic that the serde flag needs to be enabled to consume mentioned defaults.

Did not feel the change was notable so left it out of the changelog.

Closes #776

Thanks for contributing to chrono!

  • Have you added yourself and the change to the changelog? (Don't worry
    about adding the PR number)
  • If this pull request fixes a bug, does it add a test that verifies that
    we can't reintroduce it?

Makes it more clear the serde module isn't *only* for alternatives it
is also required for the default implementations.
@djc djc merged commit a383abf into chronotope:main Aug 15, 2022
@djc
Copy link
Contributor

djc commented Aug 15, 2022

Thanks!

@alextes alextes deleted the serde-docs branch August 15, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deserialization / Serialization with Serde docs
2 participants