CI: Also run tests with --no-default-features
#819
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This asserts that in addition to all tests passing with each specified feature that the tests also pass with no features at all.
There's no pretty way of gating doctests contingent on cfg presence/absense so this is kind of ugly. First, a doc comment `///` is converted into its equivalent `#[doc(...)]`, which is then converted into a conditional rust attribute via `#[cfg_attr(...)]`. We need two of these, one to ignore the tests if the cfg predicate isn't met and another to indicate the start of a code block and enable testing + syntax highlighting.
mqudsi
changed the title
--no-default-features
mqudsi
changed the title
--no-default-features--no-default-features
esheppa
approved these changes
Sep 13, 2022
|
Yes, I was thinking we should rebase it on that PR (or I should just get off my ass and review it). |
|
@mqudsi would you mind rebasing this on current 0.4.x? |
|
Thank you! Merged in #1059. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This patch configures CI to assert that
cargo test --no-default-featuresalso passes (in addition to the default combinatoric feature matrix).An additional commit is included that fixes the existing errors preventing
cargo testfrom passing under--no-default-features. The commit message explains the approach taken.This PR targets 0.5.x as some of the fixes were to 0.5.x-only impls; I'll file a separate PR for 0.4.x after this one lands in case any changes are needed or requested.
I don't know if any of the CI matrix configurations will fail with the new test so I'm pushing this to initiate a CI run against it. If any fail, I'll revise the branch to address them accordingly.