Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SPDX license expression #857

Closed
wants to merge 29 commits into from
Closed

Use SPDX license expression #857

wants to merge 29 commits into from

Conversation

keymandll
Copy link

Updated the Cargo.toml to use a valid (up-to-date) SPDX license expression.

esheppa and others added 29 commits August 29, 2022 10:52
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
Co-authored-by: Dirkjan Ochtman <dirkjan@ochtman.nl>
…ules

The internal structs can be moved into their respective modules
because `pub(super)` is now supported by the MSRV.
As discussed in #263. Note that this breaks existing code that did not
explicitly specify the offset in calls to `DateTime::parse_from_*`, as
they are now ambiguous.

Relies on #271 for conversion back into `DateTime<Utc>` from
`DateTime<FixedOffset>` as the latter is used under the hood.
Clarify the behavior of the parse methods, the relationship between ISO 8601 and
RFC 3339, and use a brief description on the first line of each function's
rustdoc to keep the resulting documentation pretty and concise.
Construct NaiveDateTime from millis since epoch
https://rustsec.org/advisories/RUSTSEC-2021-0127

criterion v0.3 contained an unmaintained crate which seemed to contained another security issue that eas fixed in v0.04.

All tests passed.
Update Cargo.toml to use a valid SPDX license expression.
@esheppa
Copy link
Collaborator

esheppa commented Oct 30, 2022

Thanks for submitting this @keymandll - It looks as though you have checked out from the main branch and then targeted the 0.4.x branch here. If possible can you check out a new branch from 0.4.x locally and then cherry pick your commits there?

@keymandll
Copy link
Author

Oops. Sure, @esheppa , will do as soon as I have some time again. Until then, I will just close the PR.

@keymandll keymandll closed this Oct 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

9 participants