Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add read-indices to ISequenceReader protocol. #109

Merged
merged 1 commit into from Sep 8, 2017

Conversation

alumi
Copy link
Member

@alumi alumi commented Sep 8, 2017

Summary

Add read-indices to ISequenceReader protocol, which was defined only for FASTA but not for 2bit.
Also defined an alias function in cljam.io.sequence.

Tests

  • lein test :all 馃啑

@codecov
Copy link

codecov bot commented Sep 8, 2017

Codecov Report

Merging #109 into master will increase coverage by 0.03%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #109      +/-   ##
==========================================
+ Coverage   85.24%   85.28%   +0.03%     
==========================================
  Files          61       61              
  Lines        4020     4029       +9     
  Branches      400      400              
==========================================
+ Hits         3427     3436       +9     
  Misses        193      193              
  Partials      400      400
Impacted Files Coverage 螖
src/cljam/io/protocols.clj 100% <酶> (酶) 猬嗭笍
src/cljam/io/sequence.clj 97.14% <100%> (+0.17%) 猬嗭笍
src/cljam/io/fasta/core.clj 90.74% <100%> (+0.17%) 猬嗭笍
src/cljam/io/twobit/reader.clj 78.62% <100%> (+1.02%) 猬嗭笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update b143168...8e6c598. Read the comment docs.

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totakke totakke merged commit 2e1a4d1 into master Sep 8, 2017
@totakke totakke deleted the feature/read-indices branch September 8, 2017 06:30
@alumi
Copy link
Member Author

alumi commented Sep 8, 2017

Thanks! 馃樃

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants