Extract region utils to cljam.util.region and add some functions. #110
Conversation
Codecov Report
@@ Coverage Diff @@
## master #110 +/- ##
=========================================
+ Coverage 85.28% 85.5% +0.22%
=========================================
Files 61 62 +1
Lines 4029 4085 +56
Branches 400 399 -1
=========================================
+ Hits 3436 3493 +57
Misses 193 193
+ Partials 400 399 -1
Continue to review full report at Codecov.
|
src/cljam/tools/cli.clj
Outdated
| @@ -16,7 +16,8 @@ | |||
| [cljam.algo.pileup :as plp] | |||
| [cljam.algo.convert :as convert] | |||
| [cljam.algo.level :as level] | |||
| [cljam.util :as util]) | |||
| [cljam.util :as util] | |||
There was a problem hiding this comment.
cljam.util seems no more needed.
There was a problem hiding this comment.
Thanks. Removed the requirement.
src/cljam/util/region.clj
Outdated
| (do (vreset! last-reg x) r))))))) | ||
| ([^long max-gap-merged regs] | ||
| (merge-regions max-gap-merged regs #(update %1 :end max (:end %2)))) | ||
| ([^long max-gap-merged regs merge-fn] |
There was a problem hiding this comment.
I think merge-fn should be located in front like clojure.core/merge-with ([f & maps]). The last regs is convenient for sequence processing such as ->>.
There was a problem hiding this comment.
Sorry, that is a problem with the order of multi-arity function. Umm, if so, it may be better to provide merge-regions-with function ...?
There was a problem hiding this comment.
Thanks! That's a good idea! I split the function into merge-regions-with and merge-regions.
src/cljam/util/region.clj
Outdated
|
|
||
| (defn complement-regions | ||
| "Returns a sequence of regions complement to in-regions. | ||
| in-regoins must be sorted. |
alumi
force-pushed
the
feature/region-manipulations
branch
from
f1b6447
to
cbe4dd7
Compare
|
Thanks :) |
|
Thank you for the helpful advice! |
Summary
cljam.utiltocljam.util.regionmerge-regions,subtract-regionandcomplement-regionsTests
lein test :all馃啑