Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some serialization functions. #122

Merged
merged 3 commits into from Nov 13, 2017
Merged

Fix some serialization functions. #122

merged 3 commits into from Nov 13, 2017

Conversation

alumi
Copy link
Member

@alumi alumi commented Nov 13, 2017

Summary

Minor fixes for performance improvement and file compatibility.

Changes

  • Replace (apply str (interpose ...)) with clojure.stirng/join.
  • Use CharBuffer to serialize FASTQ.
  • Use \tab for delimiting BED fields.

Tests

  • lein test :all 馃啑

@codecov
Copy link

codecov bot commented Nov 13, 2017

Codecov Report

Merging #122 into master will decrease coverage by 0.09%.
The diff coverage is 85.29%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #122     +/-   ##
=========================================
- Coverage   84.91%   84.81%   -0.1%     
=========================================
  Files          62       62             
  Lines        4196     4196             
  Branches      412      415      +3     
=========================================
- Hits         3563     3559      -4     
- Misses        221      222      +1     
- Partials      412      415      +3
Impacted Files Coverage 螖
src/cljam/io/vcf/writer.clj 82.75% <100%> (-0.99%) 猬囷笍
src/cljam/io/bed.clj 87.9% <100%> (+0.5%) 猬嗭笍
src/cljam/io/fastq.clj 88.03% <72.22%> (-3.56%) 猬囷笍

Continue to review full report at Codecov.

Legend - Click here to learn more
螖 = absolute <relative> (impact), 酶 = not affected, ? = missing data
Powered by Codecov. Last update 8cb494b...516a250. Read the comment docs.

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totakke totakke merged commit 73744c2 into master Nov 13, 2017
@alumi
Copy link
Member Author

alumi commented Nov 13, 2017

Thank you! 馃樃

@alumi alumi deleted the fix/apply-str-interpose branch November 13, 2017 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants