Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dependencies #134

Merged
merged 10 commits into from Jun 22, 2018
Merged

Upgrade dependencies #134

merged 10 commits into from Jun 22, 2018

Conversation

alumi
Copy link
Member

@alumi alumi commented Jun 22, 2018

Summary

@alumi alumi requested a review from totakke June 22, 2018 07:23
@codecov
Copy link

codecov bot commented Jun 22, 2018

Codecov Report

Merging #134 into master will increase coverage by <.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #134      +/-   ##
==========================================
+ Coverage   85.48%   85.49%   +<.01%     
==========================================
  Files          69       69              
  Lines        4437     4439       +2     
  Branches      418      418              
==========================================
+ Hits         3793     3795       +2     
  Misses        226      226              
  Partials      418      418
Impacted Files Coverage Δ
src/cljam/io/bam/decoder.clj 86.4% <0%> (+0.05%) ⬆️
src/cljam/io/vcf/writer.clj 82.9% <0%> (+0.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 40c47e2...b8297e0. Read the comment docs.

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@totakke totakke merged commit 8a46a60 into master Jun 22, 2018
@totakke
Copy link
Member

totakke commented Jun 22, 2018

Thank you!

@totakke totakke deleted the fix/upgrade-deps branch June 22, 2018 08:00
@alumi
Copy link
Member Author

alumi commented Jun 22, 2018

Thank you for the reviewing! 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants