New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix I/O of variants with empty info/individual fields #167
Conversation
Codecov Report
@@ Coverage Diff @@
## master #167 +/- ##
==========================================
+ Coverage 86.51% 86.53% +0.02%
==========================================
Files 73 73
Lines 5619 5624 +5
Branches 492 491 -1
==========================================
+ Hits 4861 4867 +6
Misses 266 266
+ Partials 492 491 -1
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 👍
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thank you for the consideration.
Summary
This PR fixes three minor bugs in VCF/BCF I/O
:info {}
does not emit.
(VCF)cljam/test/cljam/io/vcf/writer_test.clj
Lines 50 to 51 in f91f816
cljam/test/cljam/io/vcf/writer_test.clj
Lines 62 to 63 in f91f816
e.g. Reading
DP:HQ 4:51,51 2
does not assoc:HQ nil
to the 2nd sample.cljam/test/cljam/test_common.clj
Lines 711 to 714 in f91f816
Tests
lein check
🆗lein test :all
🆗lein cloverage
🆗lein eastwood
🆗