Provide a default file format version for BCF #170
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alumi
force-pushed
the
fix/bcf-default-version
branch
from
832cdf3
to
581438a
Compare
Codecov Report
@@ Coverage Diff @@
## master #170 +/- ##
==========================================
+ Coverage 86.87% 86.88% +<.01%
==========================================
Files 73 73
Lines 5663 5667 +4
Branches 481 481
==========================================
+ Hits 4920 4924 +4
Misses 262 262
Partials 481 481
Continue to review full report at Codecov.
|
ghost
requested review from
yito88
reviewed
Jul 1, 2019
alumi
force-pushed
the
fix/bcf-default-version
branch
from
581438a
to
54b217e
Compare
r6eve
reviewed
Jul 2, 2019
r6eve
approved these changes
Jul 2, 2019
|
Thank you for the point out. |
|
I've modified the JDK versions used in CI. |
|
Great catch! I merge it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR depends on #169The actual diff is 94ce1f8...581438a
Like VCFWriter, this PR provides a default file format version
"VCFv4.3"for meta-info of BCF.Though BCF has its version in the magic number
BCF\2\2, the header string should start with##fileformat=.