Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix nonintentional paths #172

Merged
merged 1 commit into from Jul 16, 2019
Merged

Fix nonintentional paths #172

merged 1 commit into from Jul 16, 2019

Conversation

r6eve
Copy link
Contributor

@r6eve r6eve commented Jul 16, 2019

temp-dir has a type of java.lang.String and the end is not "/", so "/" is needed when concatenating temp-dir with files.
This PR fixes nonintentional paths that do not contain "/", does not change the test results.

@r6eve r6eve added the bug label Jul 16, 2019
@r6eve r6eve requested a review from alumi as a code owner July 16, 2019 01:41
@r6eve r6eve requested a review from a team July 16, 2019 01:41
@ghost ghost requested review from yito88 and removed request for a team July 16, 2019 01:41
alumi
alumi approved these changes Jul 16, 2019
View reviewed changes
Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 Thanks!!

yito88
yito88 approved these changes Jul 16, 2019
View reviewed changes
Copy link
Contributor

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alumi alumi merged commit 0a52750 into master Jul 16, 2019
@alumi alumi deleted the fix/file-paths branch July 16, 2019 03:01
@r6eve
Copy link
Contributor Author

r6eve commented Jul 16, 2019

Thanks for the review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alumi alumi alumi approved these changes

@yito88 yito88 yito88 approved these changes

Assignees

@yito88 yito88

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r6eve @alumi @yito88