Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reflection warnings #175

Merged
merged 1 commit into from Aug 21, 2019
Merged

Fix reflection warnings #175

merged 1 commit into from Aug 21, 2019

Conversation

r6eve
Copy link
Contributor

@r6eve r6eve commented Aug 21, 2019

This PR avoids all reflections except those of external libraries when running lein with-profile +dev test.

@r6eve r6eve requested a review from alumi as a code owner August 21, 2019 07:43
@r6eve r6eve requested a review from a team August 21, 2019 07:43
@ghost ghost requested review from yito88 and removed request for a team August 21, 2019 07:43
alumi
alumi approved these changes Aug 21, 2019
View reviewed changes
Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

yito88
yito88 approved these changes Aug 21, 2019
View reviewed changes
Copy link
Contributor

@yito88 yito88 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@alumi alumi merged commit 98e6d53 into master Aug 21, 2019
@alumi alumi deleted the fix/reflection-warnings branch August 21, 2019 08:10
@alumi
Copy link
Member

alumi commented Aug 21, 2019

Thanks ✌️

@r6eve
Copy link
Contributor Author

r6eve commented Aug 21, 2019

Thanks for the reviews!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alumi alumi alumi approved these changes

@yito88 yito88 yito88 approved these changes

Assignees

@yito88 yito88

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@r6eve @alumi @yito88