Fix creating temp directory to support multiple users

[r6eve]

In the current implementation of creating temporary user's directory, there are two problems: always creates the directory of the same name cljam, and doesn't delete it after all is done. That might cause Permission denied if multiple users run cljam on the same machine.

This PR fixes the behavior; with-temp-dir macro creates an unique directory, and finally deletes it. Also, fixes a path to temporary directory such that the test code creates user's directory instead of test's directory.

[codecov]

Codecov Report

Merging #178 into master will increase coverage by 0.05%.
The diff coverage is 82%.

@@            Coverage Diff             @@
##           master     #178      +/-   ##
==========================================
+ Coverage   86.86%   86.92%   +0.05%     
==========================================
  Files          74       74              
  Lines        5750     5765      +15     
  Branches      492      490       -2     
==========================================
+ Hits         4995     5011      +16     
- Misses        263      264       +1     
+ Partials      492      490       -2

Impacted Files	Coverage Δ
src/cljam/algo/level.clj	85.1% <80%> (+2.12%)	⬆️
src/cljam/util.clj	91.22% <81.81%> (-3.65%)	⬇️
src/cljam/algo/sorter.clj	92.23% <84.61%> (+2.61%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9c9f787...28fb728. Read the comment docs.

[alumi]

Thank you for working on this feature! Added a comment about the deletion.

[r6eve]

Thanks for the speedy review! I missed out recursive deletions.

I've added missing features of recursive deletions, and the tests.

[r6eve]

Sorry for my late push. I fixed miss test's directory a little bit more.

[r6eve]

Sorry, I deleted extra spacing.

[alumi]

Thanks! Looks good other than indentation 👍

[alumi]

Thanks for the quick update! 👍

[athos]

The expanded form of this macro looks somewhat large. More importantly, it contains a reify form in it, which would redundantly generate a dedicated anonymous class for each macro callsite.

How about breaking the implementation down into some functions like create-temp-dir and delete-temp-dir, and using them in the expanded form?

[athos]

Hi, thanks for another improvement!

Just added a comment on the implementation of the macro.

[r6eve]

Thank you for the helpful suggestion! I didn't know that.
To avoid the costs, I decided to make two functions and use them in expanded forms. 4820564

[athos]

Ah, sorry if I confused you 🙇

I think providing with-temp-dir as an internal utility is completely fine. By "using them (the functions) in the expanded form", I just meant something like:

(defmacro with-temp-dir [bindings & body]
  (cond ...
        (symbol? (bindings 0))
        (let [[dir prefix] bindings]
          `(let [~dir (create-temp-dir ~prefix)]
             (try
               (with-temp-dir ~(subvec bindings 2) ~@body)
               (finally
                 (delete-temp-dir! ~dir)))))
        ...))

[r6eve]

Thank you for reviewing and I apologize for my poor understanding.
I fixed them and squashed the commits into two commits.

[athos]

LGTM 👍I will merge it, thanks!

[r6eve]

Thank you for correcting me and merging!