Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix float reader for specific environments such as IcedTea. #185

Merged
merged 1 commit into from Jan 8, 2020
Merged

Fix float reader for specific environments such as IcedTea. #185

merged 1 commit into from Jan 8, 2020

Conversation

niyarin
Copy link
Contributor

@niyarin niyarin commented Jan 8, 2020

In some environments such as "IcedTea",Float reader in Bcf reader doesn't work as expected.
Specifically, the result of reading NaN is expected to be 0x800001, but the result will be different.
The fix is ​​to read as int and convert to float if not NaN.

@niyarin niyarin requested a review from alumi as a code owner January 8, 2020 08:03
@niyarin niyarin requested a review from a team January 8, 2020 08:03
@ghost ghost requested review from r6eve and removed request for a team January 8, 2020 08:03
@codecov
Copy link

codecov bot commented Jan 8, 2020 •
edited

Codecov Report

Merging #185 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #185   +/-   ##
=======================================
  Coverage   86.64%   86.64%           
=======================================
  Files          76       76           
  Lines        6011     6011           
  Branches      499      499           
=======================================
  Hits         5208     5208           
  Misses        304      304           
  Partials      499      499
Impacted Files Coverage Δ
src/cljam/io/bcf/reader.clj 90.32% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f3bee34...56da0fb. Read the comment docs.

@alumi alumi added the bug label Jan 8, 2020
@niyarin
Copy link
Contributor Author

niyarin commented Jan 8, 2020

Sorry,I missed warning.I'll fix it.

r6eve
r6eve approved these changes Jan 8, 2020
View reviewed changes
Copy link
Contributor

@r6eve r6eve left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

alumi
alumi approved these changes Jan 8, 2020
View reviewed changes
Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@alumi alumi merged commit ddfbec0 into master Jan 8, 2020
@alumi alumi deleted the fix/float-reader branch January 8, 2020 11:56
@alumi
Copy link
Member

alumi commented Jan 8, 2020

Thanks!!

@niyarin
Copy link
Contributor Author

niyarin commented Jan 8, 2020

Thank you for reviewing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alumi alumi alumi approved these changes

@r6eve r6eve r6eve approved these changes

Assignees

@alumi alumi

Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@niyarin @alumi @r6eve