Add support for nclist. #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #211 +/- ##
==========================================
+ Coverage 87.23% 88.74% +1.50%
==========================================
Files 78 76 -2
Lines 6347 6292 -55
Branches 511 436 -75
==========================================
+ Hits 5537 5584 +47
+ Misses 299 272 -27
+ Partials 511 436 -75
Continue to review full report at Codecov.
|
alumi
reviewed
Oct 5, 2020
niyarin
force-pushed
the
feature/nclist-intervals
branch
from
784db13
to
7b6b0c2
Compare
|
Thank you for pointing. I fixed them. |
alumi
approved these changes
Oct 12, 2020
athos
reviewed
Oct 14, 2020
src/cljam/util/intervals.clj
Outdated
Comment on lines
21
to
28
| (when-let [target-intervals | ||
| (->> (subseq nclist >= start) | ||
| (map second) | ||
| (take-while #(<= (:start (first %)) end)))] | ||
| (mapcat #(cons (first %) | ||
| (find-nclist-overlap-intervals (second %) | ||
| start end)) | ||
| target-intervals))) |
There was a problem hiding this comment.
Although it wouldn't cause a real problem, the conditional of this when-let will always be evaluated to a truthy value since take-while always returns a non-nil value. You can rewrite this as:
(some->> (subseq nclist >= start)
(map second)
(take-while #(<= (:start (first %)) end))
seq
(mapcat #(cons (first %)
(find-nclist-overlap-intervals (second %)
start end))))Or simply:
(->> (subseq nclist >= start)
(map second)
(take-while #(<= (:start (first %)) end))
(mapcat #(cons (first %)
(find-nclist-overlap-intervals (second %)
start end))))
|
I removed unnecessary when-let. |
athos
approved these changes
Oct 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pr adds support for Nested Containment List (NCList).