Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update actions/setup-java to v2 #226

Merged
merged 1 commit into from
Apr 12, 2021

Conversation

alumi
Copy link
Member

@alumi alumi commented Apr 8, 2021

Related to: #224

The differences between v1 and v2 are listed in https://github.com/actions/setup-java#v2-vs-v1

  • v2 requires distribution: value, which is set to adopt here
  • v2 requires java-version: to be a SemVer

@alumi alumi requested a review from a team as a code owner April 8, 2021 09:03
@alumi alumi requested review from athos and xckitahara and removed request for a team April 8, 2021 09:03
Copy link
Member

@athos athos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@athos athos removed their assignment Apr 8, 2021
Copy link
Contributor

@xckitahara xckitahara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:

@xckitahara xckitahara merged commit bec4651 into master Apr 12, 2021
@xckitahara xckitahara deleted the feature/github-actions-setup-java-v2 branch April 12, 2021 00:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants