Avoid StackOverflowError while reading a VCF with many lines of meta #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…meta
With current implementation, many lines of meta (say 4k lines of contig definition) causes StackOverflowError like below.
```
:cause nil
:via
[{:type java.lang.StackOverflowError
:message nil
:at [clojure.lang.PersistentHashMap$BitmapIndexedNode ensureEditable "PersistentHashMap.java" 812]}]
:trace
[[clojure.lang.PersistentHashMap$BitmapIndexedNode ensureEditable "PersistentHashMap.java" 812]
[clojure.lang.PersistentHashMap$BitmapIndexedNode assoc "PersistentHashMap.java" 894]
[clojure.lang.PersistentHashMap$TransientHashMap doAssoc "PersistentHashMap.java" 327]
[clojure.lang.ATransientMap assoc "ATransientMap.java" 64]
[clojure.lang.PersistentHashMap create "PersistentHashMap.java" 78]
[clojure.core$hash_map invokeStatic "core.clj" 389]
[clojure.core$hash_map doInvoke "core.clj" 381]
[clojure.lang.RestFn applyTo "RestFn.java" 137]
[clojure.core$apply invokeStatic "core.clj" 667]
[clojure.core$apply invoke "core.clj" 662]
[cljam.io.vcf.reader$parse_data_line invokeStatic "reader.clj" 173]
[cljam.io.vcf.reader$parse_data_line invoke "reader.clj" 154]
[cljam.io.vcf.reader$read_data_lines invokeStatic "reader.clj" 181]
[cljam.io.vcf.reader$read_data_lines invoke "reader.clj" 175]
[cljam.io.vcf.reader$read_data_lines invokeStatic "reader.clj" 183]
;; continues recursive call's stack trace
```
I fixed the problem explicitly call `recur` to utlize tail call optimization.
Codecov Report
@@ Coverage Diff @@
## master #252 +/- ##
=======================================
Coverage 88.70% 88.70%
=======================================
Files 76 76
Lines 6305 6305
Branches 438 438
=======================================
Hits 5593 5593
Misses 274 274
Partials 438 438
Continue to review full report at Codecov.
|
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With current implementation, many lines of meta (say 4k lines of contig definition) causes StackOverflowError like below.
I fixed the problem by explicitly calling
recurto utilize tail call optimization.