Refine unused code for newline #51
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #51 +/- ##
==========================================
+ Coverage 73.36% 73.86% +0.49%
==========================================
Files 56 56
Lines 3293 3287 -6
Branches 329 334 +5
==========================================
+ Hits 2416 2428 +12
+ Misses 548 525 -23
- Partials 329 334 +5
Continue to review full report at Codecov.
|
totakke
requested changes
Apr 19, 2017
src/cljam/fasta/reader.clj
Outdated
| @@ -131,6 +121,9 @@ | |||
| (.clear ~buffer) | |||
| ba#))) | |||
|
|
|||
| (def ^:private gt-byte (byte \>)) | |||
| (def ^:private newline-byte (byte \newline)) | |||
There was a problem hiding this comment.
Please add ^:const to these vars for equivalence of the original code.
There was a problem hiding this comment.
Thanks to your review. I fixed it by 3c4fcdd .
alumi
approved these changes
Apr 19, 2017
totakke
approved these changes
Apr 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
newline-character,return-character,newline*?andnewline?were not used, refine it.