Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue #61 (6) Examine result file of dedupe in test #63

Merged
merged 2 commits into from Apr 25, 2017

Conversation

ayamada
Copy link
Contributor

@ayamada ayamada commented Apr 21, 2017

No description provided.

@codecov-io
Copy link

codecov-io commented Apr 21, 2017

Codecov Report

Merging #63 into master will increase coverage by 0.22%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #63      +/-   ##
==========================================
+ Coverage    82.4%   82.62%   +0.22%     
==========================================
  Files          56       55       -1     
  Lines        3285     3281       -4     
  Branches      363      362       -1     
==========================================
+ Hits         2707     2711       +4     
+ Misses        215      208       -7     
+ Partials      363      362       -1
Impacted Files Coverage Δ
src/cljam/bam/writer.clj 76.86% <0%> (ø) ⬆️
src/cljam/main.clj
src/cljam/bam/decoder.clj 86.01% <0%> (+1.39%) ⬆️
src/cljam/sorter.clj 79.31% <0%> (+3.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4a65d3c...d819a5e. Read the comment docs.

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Copy link
Member

@totakke totakke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Umm... small.bam seems to have no duplicates because contents of small.bam and small.deduped.bam are totally same. Although This behavior is right, I think small.bam is not appropriate for dedupe test.

@ayamada
Copy link
Contributor Author

ayamada commented Apr 24, 2017

Thanks for review, I changes to new bam files based on another dedupe test.
Is it OK?

@totakke totakke merged commit 912842c into chrovis:master Apr 25, 2017
@totakke
Copy link
Member

totakke commented Apr 25, 2017

Great:) Thank you.

@ayamada ayamada deleted the feature/test-check-deduped-file branch April 28, 2017 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants