Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix test of BCF writer #82

Merged
merged 2 commits into from Jun 15, 2017
Merged

Fix test of BCF writer #82

merged 2 commits into from Jun 15, 2017

Conversation

totakke
Copy link
Member

@totakke totakke commented Jun 15, 2017

Fixes test redefinition and order of arg vec and docstring.

@totakke totakke requested a review from alumi June 15, 2017 10:16
@codecov
Copy link

codecov bot commented Jun 15, 2017

Codecov Report

Merging #82 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #82   +/-   ##
=======================================
  Coverage   83.02%   83.02%           
=======================================
  Files          62       62           
  Lines        4160     4160           
  Branches      430      430           
=======================================
  Hits         3454     3454           
  Misses        276      276           
  Partials      430      430
Impacted Files Coverage Δ
src/cljam/bcf/reader.clj 90.34% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3b3c3ed...c89e038. Read the comment docs.

Copy link
Member

@alumi alumi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alumi alumi merged commit 67a7737 into master Jun 15, 2017
@alumi alumi deleted the fix/bcf-writer-test branch June 15, 2017 15:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants