Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix commented tests #85

Merged
merged 1 commit into from Jun 22, 2017
Merged

Fix commented tests #85

merged 1 commit into from Jun 22, 2017

Conversation

totakke
Copy link
Member

@totakke totakke commented Jun 22, 2017

I forgot to fix commented tests of predicates and old reader/writer in cljam.io.util. This PR fixes them.

@codecov
Copy link

codecov bot commented Jun 22, 2017

Codecov Report

Merging #85 into master will increase coverage by 0.72%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #85      +/-   ##
==========================================
+ Coverage    81.9%   82.63%   +0.72%     
==========================================
  Files          60       60              
  Lines        4140     4140              
  Branches      432      432              
==========================================
+ Hits         3391     3421      +30     
+ Misses        317      287      -30     
  Partials      432      432
Impacted Files Coverage Δ
src/cljam/io/vcf.clj 94.73% <0%> (+5.26%) ⬆️
src/cljam/io/sam.clj 97.77% <0%> (+8.88%) ⬆️
src/cljam/io/sequence.clj 96.42% <0%> (+21.42%) ⬆️
src/cljam/io/util.clj 100% <0%> (+37.5%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2e93bc5...1f963c7. Read the comment docs.

@totakke totakke requested a review from alumi June 22, 2017 07:57
@alumi alumi merged commit 6da224e into master Jun 22, 2017
@alumi alumi deleted the fix/commented-test branch June 22, 2017 08:06
@alumi
Copy link
Member

alumi commented Jun 22, 2017

Merged. Thank you for the fixes!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants