Fix isMonoAudioEnabled accessibility method #24
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@edwellbrook: Thanks for the contribution. 鉂わ笍 Indeed, it was using the wrong method. I'm trying to test as much as possible to provide a good test coverage, however these kind of things are almost impossible to unit test. 馃憤 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue information
馃摑 looks like isMonoAudioEnabled was using the wrong method
Goal
馃摑 use the right method
Implementation
馃摑 change
UIAccessibilityIsSpeakScreenEnabledtoUIAccessibilityIsMonoAudioEnabledTesting
馃摑 none