Makefile.PL: check Tcl/Tk installation via Tcl.pm #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrstphrchvz
commented
Feb 12, 2021
Comment on lines
+6
to
+14
| my $i; | ||
| my $tk_patchLevel; | ||
|
|
||
| sub _die ($) { | ||
| # CPAN smokers report FAIL if Makefile.PL dies, it should exit with status 0 | ||
| my $err = shift; | ||
| warn $err; | ||
| # Cleanly exit Tcl/Tk if it was loaded | ||
| $i->Eval('destroy .') if ($tk_patchLevel); |
There was a problem hiding this comment.
To avoid issues related to #14, if Tk is loaded then the root Tk window is destroyed before Makefile.PL exits.
chrstphrchvz
commented
Feb 12, 2021
chrstphrchvz
commented
Feb 12, 2021
There was a problem hiding this comment.
It is suggested to use eval { …; 1; } or do { my $error = $@ || 'unknown error'; … } instead of eval { … }; if ($@) {…}.
https://perlmaven.com/fatal-errors-in-external-modules
chrstphrchvz
force-pushed
the
new-test-for-tk
branch
from
f066c9f
to
fa71eec
Compare
|
This idea has since been implemented for Tkx (although that was simpler due to not checking for any Tk extensions): chrstphrchvz/tkx@5d0230d |
chrstphrchvz
force-pushed
the
trunk
branch
3 times, most recently
from
d83b200
to
87428a0
Compare
8.4 already required since Tcl.pm 0.81 (released 2004).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An idea I brought up on perl.tcltk: https://www.nntp.perl.org/group/perl.tcltk/2020/07/msg840.html
The goal is to use Tcl.pm to check the Tcl/Tk installation rather than find/ask for and run tclsh. This avoids the possibility of checking a Tcl/Tk installation other than the one Tcl.pm is configured to use.