Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: align cover svg to viewer #167

Merged
merged 5 commits into from Jan 5, 2020
Merged

Conversation

wolasss
Copy link
Contributor

@wolasss wolasss commented Dec 7, 2019

These changes allow to call:

viewer.fitToViewer(ALIGN_COVER, ALIGN_COVER) so that the svg will always take the whole viewport and match the viewport by the short edge.

Please review and let me know if there is something else I must add

@wolasss
Copy link
Contributor Author

wolasss commented Dec 7, 2019

It fixes #29

@coveralls
Copy link

coveralls commented Dec 7, 2019

Coverage Status

Coverage increased (+0.7%) to 39.652% when pulling a31979e on wolasss:master into 1b3bb5e on chrvadala:master.

@wolasss
Copy link
Contributor Author

wolasss commented Dec 13, 2019

@chrvadala hey, any chances this will be merged soon? :)

Copy link
Owner

@chrvadala chrvadala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, thanks for your contributions.
I added few feedbacks inline; moreover, can you provide some unit tests?

Finally, let me to suggest you to align your PR with the add-test branch https://github.com/chrvadala/react-svg-pan-zoom/tree/add-tests, because I'll merge it in the next few days

docs/documentation.md Outdated Show resolved Hide resolved
package-lock.json Outdated Show resolved Hide resolved
@chrvadala
Copy link
Owner

Hi, thanks for your contributions.
I added few feedbacks inline; moreover, can you provide some unit tests?

Finally, let me to suggest you to align your PR with the add-test branch https://github.com/chrvadala/react-svg-pan-zoom/tree/add-tests, because I'll merge it in the next few days

quick update: add-tests is merged! you can sync your branch with master

@wolasss
Copy link
Contributor Author

wolasss commented Dec 13, 2019

Ok, thanks, I'll address all the issues after the weekend

@wolasss
Copy link
Contributor Author

wolasss commented Dec 16, 2019

@chrvadala I added some unit tests - for two scenarios where rect > viewport and the opposite. Both cases seem to be working fine. I also removed the package-lock.json and removed the blank lines.

@chrvadala chrvadala merged commit 69b5b19 into chrvadala:master Jan 5, 2020
@chrvadala
Copy link
Owner

Released with version 3.8.0
Thanks for your contribution, I added you in contributors list

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants