You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
The implementations of transform() and compose currently accept either multiple Matrix parameters or a single Matrix[] parameter. Unfortunately, the current type definitions do not cover the case of a single Matrix[] parameter. This requires TypeScript code to be written as transform(...fromDefinition(arrayOfDefinitions)) when in fact, the ... should be uneccessary.
I propose adding the following overloads without ...:
export function transform(matrices: Matrix[]): Matrix;
export function compose(matrices: Matrix[]): Matrix;
These would appear adjacent to the following lines:
The implementations of
transform()
andcompose
currently accept either multipleMatrix
parameters or a singleMatrix[]
parameter. Unfortunately, the current type definitions do not cover the case of a singleMatrix[]
parameter. This requires TypeScript code to be written astransform(...fromDefinition(arrayOfDefinitions))
when in fact, the...
should be uneccessary.I propose adding the following overloads without
...
:These would appear adjacent to the following lines:
transformation-matrix/transformation-matrix.d.ts
Line 136 in 06321d4
transformation-matrix/transformation-matrix.d.ts
Line 143 in 06321d4
And the documentation can be improved by changing the parameter description as follows:
transformation-matrix/src/transform.js
Line 3 in 06321d4
transformation-matrix/src/transform.js
Line 39 in 06321d4
The text was updated successfully, but these errors were encountered: