-
Notifications
You must be signed in to change notification settings - Fork 119
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow server transport selection, allow ws server to choose random bind port #270
Conversation
Hello, just checking in. This and the other API issue (#271) will probably be a blocker for my pull request to Home Assistant so if there's anything you need from me here I'd be happy to help. |
Any feedback here? I can split this into two PRs if that makes sense. |
Hello, I updated this a bit to keep the +3000 offset but only apply it if the port isn't zero. This allows dynamic server port selection while retaining the original behavior for actual port numbers. What do you think? |
@chrysn Sorry for the ping. We've been holding back releasing coap support in HKC a few months waiting for a solution so it would be great to get this merged and released. Thanks! |
Thanks for the ping, and sorry I missed this. The fixes are good conceptually; I'll add a note that this precise ( Adjusting a few style nits and merging ASAP. Can you work from a (pinned, I hope) version of the master branch, or will you need a pypi release? HKC ... not sure of the abbreviation, but if it doesn't overlap with what has been reported in #277 I'd appreciated a note there. |
👍
We need a PyPI release.
HKC is HomeKit Controller |
Thank you! |
I'm not sure about the background of the ws.py FIXME comment