Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect non-interactive terminals automatically #58

Closed
chshersh opened this issue Aug 7, 2022 · 4 comments
Closed

Detect non-interactive terminals automatically #58

chshersh opened this issue Aug 7, 2022 · 4 comments
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/ help wanted Extra attention is needed
Milestone
v0.1.0.0: Improve...

Comments

@chshersh
Copy link
Owner

chshersh commented Aug 7, 2022 •
edited

Currently, it's possible to disable interactivity by specifying the --no-input options. But some terminals are non-interactive by nature (e.g. on CI). So it would be great to check this and specify the value of InteractiveMode automatically.
@chshersh chshersh added terminal good first issue Good for newcomers help wanted Extra attention is needed labels Aug 7, 2022
@chshersh chshersh added this to the v0.1.0.0: Improved UX milestone Sep 2, 2022
@chshersh chshersh pinned this issue Sep 2, 2022
@chshersh chshersh added hacktoberfest https://hacktoberfest.com/ and removed hacktoberfest https://hacktoberfest.com/ labels Sep 27, 2022
@german1608
Copy link
Contributor

Would checking the $- environment variable suffice?

@marcellourbani
Copy link
Contributor

I believe one should use hSupportsANSI from ansi-terminal

@marcellourbani
Copy link
Contributor

will have a go

marcellourbani added a commit to marcellourbani/iris that referenced this issue Oct 5, 2022
@marcellourbani
fixes chshersh#58 detect non interactive terminals
e3daed8
@chshersh
Copy link
Owner Author

chshersh commented Oct 6, 2022

Checking $- is a valid option. But it would be nice to have a cross-platform solution.

marcellourbani added a commit to marcellourbani/iris that referenced this issue Oct 8, 2022
@marcellourbani
fixes chshersh#58 detect non interactive terminals
59dc2b4
chshersh added a commit to marcellourbani/iris that referenced this issue Oct 11, 2022
@chshersh
Merge branch 'main' into fixes-chshersh#58-detect-non-interactive-ter…
8d28b45 
…minals-automatically
@chshersh chshersh unpinned this issue Nov 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
good first issue Good for newcomers hacktoberfest https://hacktoberfest.com/ help wanted Extra attention is needed
Projects
No open projects
Iris Project
Status: Done
Milestone
v0.1.0.0: Improved UX
Development

No branches or pull requests
3 participants
@marcellourbani @chshersh @german1608