-
-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrading clap to 4.0.x #136
Comments
No, I don't think so. Upgrading But we still might want to upgrade |
Could I pick this up? |
@SanchithHegde sure, im not working on it. |
Resolves #136 This PR upgrades the `clap` dependency to `4.0`. I can also upgrade the other dependencies in the same PR itself, since they only involve modifications to the `Cargo.toml` and `Cargo.lock` files, `clippy` lints and tests pass without any code modifications. ### Additional tasks - [ ] Documentation for changes provided/changed - [ ] Tests added - [ ] Updated CHANGELOG.md --- PS: I'm unsure if this requires a changelog entry, I can add one if required.
As discussed in #136 and #137, this PR upgrades dependencies to their latest versions. ### Additional tasks - [ ] Documentation for changes provided/changed - [ ] Tests added - [ ] Updated CHANGELOG.md --- Aside, have you considered setting up either Dependabot or Renovate for handling updates to both Rust dependencies and GitHub Actions?
While looking into #133 I ran into a versioning issue between clap and clap_completion. I noticed there was a 4.0 release for clap.
Is it too early to bump the clap version since the 4.0 release was on 2022 09 28? The project passes all tests and compiles and from my own testing everything works as expected. There are a couple of deprecation warnings when running
cargo clippy --features clap/deprecated
but these are easily fixable.The main advantage I see are improved help text generation and the auto completion features.
help text 3.2.17
help text 4.0.x
The shell suggestions from the last screenshot also work on 3.x.
The text was updated successfully, but these errors were encountered: