Shuffle Page Updates #3
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
chubbaluv
reviewed
Jan 27, 2024
Comment on lines
+116
to
+123
| style={{ | ||
| display: 'flex', | ||
| flexDirection: 'row', | ||
| justifyContent: 'center', | ||
| width: '40%', | ||
| transition: fadeNextCard ? 'background 5s linear' : 'none', | ||
| background: fadeNextCard ? 'white' : 'transparent', | ||
| }} |
There was a problem hiding this comment.
We can move this to the styled component. For example:
width: ${({ $fullWidth }) => ($fullWidth ? '100%' : 'min-content')};
Note the usage of $ for the prop to denote it as a transient prop and not pass it on to the DOM
chubbaluv
reviewed
Jan 27, 2024
Comment on lines
+96
to
+101
| style={{ | ||
| display: 'flex', | ||
| justifyContent: currentIndex !== 0 ? 'space-between' : 'flex-end', | ||
| marginTop: '16px', | ||
| gridColumn: '1/4' | ||
| }} |
There was a problem hiding this comment.
Same comment about styled components and passed props.
chubbaluv
reviewed
Jan 27, 2024
Comment on lines
+106
to
+107
| style={{ display: 'flex', flexDirection: 'row', justifyContent: 'center', width: '40%' }} | ||
| > |
There was a problem hiding this comment.
Same comment about styled components and passed props.
chubbaluv
reviewed
Jan 27, 2024
| @@ -55,4 +55,27 @@ export const EntryThumbnail = styled.div` | |||
| aspect-ratio: 16 / 9; | |||
| background: ${({ $backgroundImage }) => `no-repeat center / cover url(${$backgroundImage})`}; | |||
| width: 150px; | |||
| `; | |||
|
|
|||
| export const ControlButton = styled.button` | |||
There was a problem hiding this comment.
We'll want to style our already existing Button component here with
export const ControlButton = styled(Button)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will update this as PR comes along