add deprecation of the preregistred deserializer.decodertypes

chubbyphp · Oct 28, 2019 · 9c4e9c7 · 9c4e9c7
1 parent b369df9
commit 9c4e9c7
Show file tree

Hide file tree

Showing 2 changed files with 19 additions and 0 deletions.
diff --git a/src/Provider/DeserializationProvider.php b/src/Provider/DeserializationProvider.php
@@ -44,6 +44,12 @@ public function register(Container $container): void
                 $decoderTypes[] = new YamlTypeDecoder();
             }
 
+            @trigger_error(
+                'Register the decoder types by yourself:'
+                    . ' $container[\'deserializer.decodertypes\'] = function () { return [new JsonTypeDecoder()]; };',
+                E_USER_DEPRECATED
+            );
+
             return $decoderTypes;
         };
 

diff --git a/tests/Unit/Provider/DeserializationProviderTest.php b/tests/Unit/Provider/DeserializationProviderTest.php
@@ -35,6 +35,8 @@ public function testRegister(): void
         $container = new Container();
         $container->register(new DeserializationProvider());
 
+        error_clear_last();
+
         self::assertTrue(isset($container['deserializer']));
 
         self::assertTrue(isset($container['deserializer.decoder']));
@@ -70,6 +72,17 @@ public function testRegister(): void
         $reflectionProperty->setAccessible(true);
 
         self::assertInstanceOf(NullLogger::class, $reflectionProperty->getValue($denormalizer));
+
+        $error = error_get_last();
+
+        self::assertNotNull($error);
+
+        self::assertSame(E_USER_DEPRECATED, $error['type']);
+        self::assertSame(
+            'Register the decoder types by yourself:'
+                . ' $container[\'deserializer.decodertypes\'] = function () { return [new JsonTypeDecoder()]; };',
+            $error['message']
+        );
     }
 
     public function testRegisterWithDefinedLogger(): void