Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ascii table broken with some cities #192

Open
cig0 opened this issue May 9, 2018 · 17 comments
Open

Ascii table broken with some cities #192

cig0 opened this issue May 9, 2018 · 17 comments

Comments

@cig0
Copy link

cig0 commented May 9, 2018

Hi,

Please check attached screenshot:

screen shot 2018-05-08 at 22 51 00-compressed

I find this happening with many other cities as well.

Let me know if this is a wego issue instead to report the bug on their repo.
Thanks!

@ghost
Copy link

ghost commented May 18, 2018

It's not about cities, it's about Thundery part. I guess thunder emoji(?) breaks the terminal output or font because it is animated.
same

@MAGICCC
Copy link
Contributor

MAGICCC commented May 18, 2018

@slump64 yes, see here #100
But just saw that @cig0 screenshot only shows rain symbols so the drops are wide symbols as well (probably)

@chubin
Copy link
Owner

chubin commented May 18, 2018

@MAGICCC now it is not rain, it is thunder (or better to say lighting)

@chubin
Copy link
Owner

chubin commented May 18, 2018

@slump64 it is not an emoji, it is just a normal wide unicode character; I will fix it. Actually after I've added ja/ko support, that us wide characters, the fix is trivial

@ghost
Copy link

ghost commented May 18, 2018

@chubin OFFTOPIC: pretty sure the fact that this symbol is a normal wide unicode character doesn't make it an not emoji (https://emojipedia.org/high-voltage-sign/)

@chubin
Copy link
Owner

chubin commented May 18, 2018

@slump64 yes, you are right, strictly speaking it is an emoji, it would be better to write "even if it is an emoji, it does not matter, because it is just a normal wide unicode symbol and so it can be handled as such". Actually many of normal symbols are emojis, as far as I know, even such symbols as +, - and ! and so on (©️, ®️, ☯️, ™, etc. I'm not sure, but I think that all of them are emojis). Thus, you are surely right

(yes, exactly! the © symbol, as I entered it, was displayed as a normal unicode symbol; github detected an emoji in it; and now I entered is as compose-o-c, let's see what happens; I'm curious whether github will detect an emoji in our lightning character)

(as we see, it depends on the method, how you enter the character; that means that we have to copy paste some symbol to see whether it is an emoji or not)

@chubin
Copy link
Owner

chubin commented May 29, 2018

The problem was reported again: https://twitter.com/neproshennie/status/1001575302647242753

@R3l4x3
Copy link

R3l4x3 commented Jul 3, 2018

I love this tool 🙂 but unfortunately have the same display error

image

@07pepa
Copy link

07pepa commented Sep 1, 2018

also problems http://prntscr.com/kpdl56

@chubin
Copy link
Owner

chubin commented Sep 18, 2018

@07pepa What was that? Chrome?

@07pepa
Copy link

07pepa commented Sep 18, 2018

nope and i know what is causing it... it is debian in WSL

@jrcharney
Copy link

jrcharney commented Feb 23, 2019

Howdy! I'm using KiTTY as my SSH program, which is a fork of Putty to access my Raspberry Pi 3 which I've set up to use 256 colors and zsh.

I decided to browse around to see what other icons are used to represent the weather when I took notice of an area that was having thunderstorms both as part of the weather report and in the forecast.

One of the things I've noticed is how the lightning bolts' appearance.

image

I was thinking as a substitute for the ASCII/Emoji lightning icons, try ASCII Art, because this is what that forecast looks like here on Github.

Weather report: Jackson, MS

      .-.      Thunderstorm In Vicinity
     (   ).    82..86 °F
    (___(__)   ↑ 16 mph
   ‚‘⚡‘‚⚡‚‘  9 mi
   ‚’‚’⚡’‚’   0.0 in

I thought about some alternatives. After a google search to I saw this (The last example down at the bottom) and tried to minimize it. I don't think I could make it any smaller without losing some detail, but do you think you can work with something like this?

    ,/		 Lightning bolt (Similar to Corcoran's but smaller. Still too big.)
  .'/___,
.'__  ,'
   /,'
  /'

  
    ___       Lightning bolt (but this one would be a little too big)
   /  /_,
  /_  ,'
   /,'
  /'

So I came up with this. For all the following case, the lightning bolt would be colored yellow to differentiate that from rain. which would use similar characters. It would be wise that the color of the characters that make up the lightning bolt take precedence over the colors making the clouds or precipitation.

    __       Lightning bolt (raw, no clouds or precip.)
   / /_,
  /_ ,'
   /'

  

   .-.      Thunderstorm (small cloud, no precip.)
  ( __).
 (_/ /_,)
  /_ ,'
   /'
   
_`/"".-.      Thunderstorm (small cloud, no precip. with sun)
 ,\_( __).
  /(_/ /_,)
    /_ ,'
     /'

_`/"".-.      Thunderstorm (small cloud, light rain. with sun)
 ,\_( __).
  /(_/ /_,)
   ‘/_ ,' ‘
  ‘ ‘/' ‘ ‘

_`/"".-.      Thunderstorm (small cloud, light moderate/heavy rain. with sun)
 ,\_( __).
  /(_/ /_,)
  ‚‘/_ ,'‚‘
  ‚‘,/'‚‘‚‘
	 
	 
_`/"".-.      Thundersnow (small cloud, snow. with sun)
 ,\_( __).
  /(_/ /_,)
   */_ ,'*
  * */'*
	 
    .--.		Thunderstorm (large cloud, no precip.)
 .-(  __).  
(___./ /__)
    /_ ,'
     /'
	 
    .--.		Thunderstorm (large cloud, light rain.)
 .-(  __).  
(___./ /__)
 ‘ ‘/_ ,'‘
‘ ‘  /' ‘
	 
     .--.		Thunderstorm (large cloud, with moderate/heavy rain.)
  .-(  __).  
 (___./ /__)
‚‘‚‘‚/_ ,'‚‘
‚‘‚‘, /'‚‘‚‘
	 
     .--.		Thundersnow (large cloud, snow.)
  .-(  __).  
 (___./ /__)
 * * /_ ,'*
* * * /'*

Might want to move the lightning bolt to the left a little bit to make it more clear. (I wish Github would change the comment textarea to use a monospace font instead of a sans-serif. I had to whip these up in my text editor, Notepad++, which for some reason kept converting four spaces to tabs.

I didn't look up what the case would be for freezing rain, sleet, or wintry mix. But I'm sure the rules would still apply for that.

Hopefully, we will never screw up the environment bad enough to worry about lightning inside of heavy fog.

@jrcharney
Copy link

OK, let's try to make those no-sun icons look better.

    .--.		Thunderstorm (large cloud, no precip., lightning more centered)
 .-( __ ).  
(__./ /___)
   /_ ,'
    /'
	
     .--.		Thunderstorm (large cloud, no precip., lightning more centered)
  .-( __ ).  
 (__./ /___)
 ‘ ‘/_ ,' ‘
‘ ‘ ‘/'‘ ‘

     .--.		Thunderstorm (large cloud, heavy/moderate rain, lightning more centered)
  .-( __ ).  
 (__./ /___)
‚‘‚‘/_ ,'‚‘
‚‘‚‘,/'‚‘‚‘

     .--.		Thundersnow (large cloud, snow, lightning more centered)
  .-( __ ).  
 (__./ /___)
 * */_ ,'* *
* * */' * *

@jrcharney
Copy link

Now that I think of it, I should have submitted these comments to schachmat/wego

@chubin
Copy link
Owner

chubin commented Feb 23, 2019

@jrcharney Sure, you can do it, and so improve the both projects; we can use your improvements independently anyway; wego and wttr.in diverged many years ago (in 2016).

Maybe we should have create a non-unicode/non-emoji version, where only real ASCII symbols would be used? There we could the proposed by @jrcharney fixes.

Another option: we could make an option by means of which actual width of the lightning emoji could be chosen. The problem is (as you probably understand) that the with of the lighting emoji/sign varies in different terminals/browsers, so when we fix it for ones it does not work the others and other way around. But such an option could be a workaround

@nixpanic
Copy link

wttr in amsterdam_lightning-in-firefox

The problem is currently visible in Firefox 73 (on Fedora 31). No display issue on the XFCE Terminal.

@chubin
Copy link
Owner

chubin commented Feb 29, 2020

@nixpanic Niels, thank you for reporting. We should fix it some day

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

7 participants