Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wind speed formatting issue #34

Open
dlstadther opened this issue Apr 14, 2016 · 7 comments
Open

Wind speed formatting issue #34

dlstadther opened this issue Apr 14, 2016 · 7 comments

Comments

@dlstadther
Copy link

When the min and max wind speeds are both 2 digits, the line formatting becomes pushed to the right and causes mismatched ASCII images.

wttr_wind_speed

@mikelietz
Copy link

I don't think it's the two digit numbers - it's the diagonal arrows. Look how Friday morning is fine, but the rest of that day skews.

@dlstadther
Copy link
Author

Ah, yes @mikelietz you're correct. I guess I didn't look closely enough.

@schachmat
Copy link

That issue is already fixed in wego, @chubin just has to update the version running on his server.

@schachmat
Copy link

On second thought, the fix probably won't work for the curl and wget cases, since they won't send their locales and if if they would, wego would have to be called with that respective locale on the server. A workaround might be to change your locales @dlstadther (see the linked PR discussion above) if that is an option.

@chubin
Copy link
Owner

chubin commented Apr 16, 2016

Actually, it's possible, but you need to pass that info (just a bit of information) in the url. Say, if you add j to the url (curl wttr.in/osaka?j), it could mean "please fix the japan-locales-problem for me).

@schachmat
Copy link

As already mentioned the source of the issue is different locales in your own terminal and on the wttr.in server where wego is running. wego does not know your locale, so it can only use the one from the server. To get it correct you would have to somehow pass your locale to the server (no more typing just curl wttr.in/London) and the server software has to be patched to accept this new parameter and invoke wego with this specific locale. Of course the server has to have all possible locales installed and available for this. So the easy fix is to just install wego on your machine and type wego instead of curl wttr.in/London which has another benefit of being even shorter. ;-)

@deanturpin
Copy link

FWIW

Ditto in Firefox ESR 45.6.0.

The diagonal arrows are Segoe UI Symbol, the up arrows are Lucida Console. The other bits are Lucida Sans Typewriter Regular.

firefox-45 6 0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants