Errors reported back on execute

chucknorris · Feb 2, 2012 · 2e5fad5 · 2e5fad5
1 parent 3173d3d
commit 2e5fad5
Show file tree

Hide file tree

Showing 2 changed files with 11 additions and 6 deletions.
diff --git a/product/dropkick/DeploymentModel/DeploymentPlan.cs b/product/dropkick/DeploymentModel/DeploymentPlan.cs
@@ -63,6 +63,8 @@ public DeploymentResult Execute()
                 deploymentResult.MergedWith(o);
                 if (o.ContainsError())
                 {
+                    //display errors!
+                    DisplayResults(o);
                     //stop. report verify error.
                     return;
                 }

diff --git a/product/dropkick/Tasks/Files/CopyFileTask.cs b/product/dropkick/Tasks/Files/CopyFileTask.cs
@@ -45,8 +45,10 @@ public override DeploymentResult VerifyCanRun()
             _to = _path.GetFullPath(_to);
 
             ValidatePaths(result);
-
-            result.AddGood(Name);
+            if(!result.ContainsError()) {
+                //don't report back 'good' on errors
+                result.AddGood(Name);
+            }
 
             return result;
         }
@@ -59,11 +61,12 @@ public override DeploymentResult Execute()
             _to = _path.GetFullPath(_to);
 
             ValidatePaths(result);
+            if(!result.ContainsError()) {
+                //don't continue on errors
+                CopyFile(result, _newFileName, _from, _to);
 
-            CopyFile(result, _newFileName, _from, _to);
-
-            result.AddGood(Name);
-
+                result.AddGood(Name);
+            }
             return result;
         }