Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete File Task #27

Merged
merged 1 commit into from Mar 20, 2012
Merged

Delete File Task #27

merged 1 commit into from Mar 20, 2012

Conversation

a-h
Copy link

@a-h a-h commented Nov 3, 2011

I've added a DeleteFile task to DropKick. I use it to delete files on the target server, e.g. put App_Offline.htm in place, then deploy updated application, make configuration changes etc., then delete App_Offline.htm to bring it all back online.

@a-h
Copy link
Author

a-h commented Nov 10, 2011

I've had a rethink on this, I just sat down to change it to Delete().File() and I realised that there's already a CopyFile, CopyDirectory, RenameFile etc. so the DeleteFile() style seems to be consistent with what's already there.

I think it might be better as it is, or to make a breaking API change and change the other methods (CopyFile) etc. to be Copy().File() / Copy().Delete().

What do you think?

@ferventcoder
Copy link
Member

It's probably fine. I was actually thinking the API might change to that idea...let me take a look at it as is.

@ferventcoder ferventcoder merged commit 72cf993 into chucknorris:master Mar 20, 2012
@ferventcoder
Copy link
Member

Finally getting it in... sorry it took so long! Thanks for the contributions...!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants