Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added namespace support to the XmlPoke task #40

Merged
merged 1 commit into from Mar 20, 2012

Conversation

steinjak
Copy link
Contributor

@steinjak steinjak commented Mar 8, 2012

Hi there,

Thanks for creating a great tool - no more msdeploy for us ;-)! We stumbled across an issue, though, while building a deployment with dropkick: The XmlPoke task doesn't take xml namespaces into account, so we were out of luck in updating an xml file where namespaces were necessary. It was a joy to find that the source was easily readable and hackable :), so we took the liberty to extend the task.

With this extension, it's possible to pass a dictionary of namespace prefixes/urls to the XmlPoke extension method to enable namespace prefixing in the xpath queries (see enclosed test for an example).

This pull request contains our simple fix to add namespace support to XmlPoke. It adds one method overload to the public api. Don't hesitate to comment or request changes/improvements.

All the best,

steinjak

@ferventcoder
Copy link
Member

thanks!

@ferventcoder ferventcoder merged commit 030dd87 into chucknorris:master Mar 20, 2012
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants