Added namespace support to the XmlPoke task #40
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi there,
Thanks for creating a great tool - no more msdeploy for us ;-)! We stumbled across an issue, though, while building a deployment with dropkick: The XmlPoke task doesn't take xml namespaces into account, so we were out of luck in updating an xml file where namespaces were necessary. It was a joy to find that the source was easily readable and hackable :), so we took the liberty to extend the task.
With this extension, it's possible to pass a dictionary of namespace prefixes/urls to the XmlPoke extension method to enable namespace prefixing in the xpath queries (see enclosed test for an example).
This pull request contains our simple fix to add namespace support to XmlPoke. It adds one method overload to the public api. Don't hesitate to comment or request changes/improvements.
All the best,
steinjak