Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue: - custom_critters.xml crashes upon loading Salish Golden Boar #3845

Closed
KeeperM opened this issue Sep 3, 2019 · 2 comments · Fixed by #3901
Closed

Issue: - custom_critters.xml crashes upon loading Salish Golden Boar #3845

KeeperM opened this issue Sep 3, 2019 · 2 comments · Fixed by #3901
Labels

Comments

@KeeperM
Copy link

KeeperM commented Sep 3, 2019

Environment

Crash ID: b3dde2f6-135b-40f3-a2c7-10c01fea6d17
Chummer Version: 5.208.0.0
Environment: Windows 10 Home
Runtime: 4.0.30319.42000
Option upload logs set: Trace
Installation ID: 7498f263-dac6-46ec-996a-fa196e73d88a

Expected behaviour

I'm trying to add some 4E critters updated to 5E. The golden boar from "Running Wild" was tackled first. I'm hoping to convert critters from dual-statted adventure books (like "Elven Blood") which offer both 4E and 5E statblocks and eventually submit them for the next stable.

Actual behaviour

The golden boar from "Running Wild" loads if the name Golden Boar is used despite a new GUID (it's like legacy 4E code unlocks if you call a critter something from RW, and it pulls the 4E code instead of the new one). Upon changing to Salish Golden Boar, it shows the proper statblock preview as in: https://cdn.discordapp.com/attachments/523325762347073556/618456325403312149/unknown.png

However, it crashes upon an attempt to load.

Steps to reproduce the behaviour

Drop the XML into the data folder of Chummer, then apply New Critter => Paranormal Critters => Salish Golden Boar => Load.

custom_critters.zip

@cnschu
Copy link
Contributor

cnschu commented Sep 30, 2019

custom_critters.xml seems faulty.

@chummer5a
Copy link
Owner

Nah, no real problem with the XML, it's just the duplication of name. Metatype selection in the main branch is still done by name. I'm working on a fix for that in the https://github.com/chummer5a/chummer5a/tree/idbasemetatype branch, but it's a fairly chunky change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants