Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weapon Reach cap not being respected #4873

Closed
Teksura opened this issue Jul 23, 2022 · 2 comments
Closed

Weapon Reach cap not being respected #4873

Teksura opened this issue Jul 23, 2022 · 2 comments

Comments

@Teksura
Copy link
Contributor

Teksura commented Jul 23, 2022

Core p. 186:

Weapons with this feature have a Reach rating between 1 and 4.

While this does stack with natural reach such as that from a Troll or Elongated Limbs, Chummer incorrectly allows weapons modded via Special Modifications to have reach ratings greater than 4.

@chummer5a
Copy link
Owner

Hmm, I don't know if I agree with that read, but it's implementable. Recommend a new option that can either uncap it or set an integer. Ghetto workaround would be to do it in data with something like

      <required>
        <allof>
          <weapondetails>
            <reach operation="lessthan">4</reach>
          </weapondetails>
        </allof>
        <oneof>
          <specialmodificationlimit>1</specialmodificationlimit>
        </oneof>
      </required>

@chummer5a chummer5a added this to the 5.223.0 Targets milestone Aug 2, 2022
@chummer5a chummer5a modified the milestones: 5.223.0 Targets, 5.224.0 Targets Aug 15, 2022
@DelnarErsike DelnarErsike removed this from the 5.224.0 Targets milestone Nov 14, 2022
@stale
Copy link

stale bot commented Mar 19, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 19, 2023
@stale stale bot closed this as completed Apr 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants